Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Update Angular to use package:observable #1761

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tvolkert
Copy link

@tvolkert tvolkert commented Oct 1, 2016

No description provided.

Copy link

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approval.

@matanlurey
Copy link

@tvolkert I am seeing a pub error:

Package observe has no versions that match >=0.14.0 <0.15.0 derived from:
- angular depends on version ^0.14.0

@rkirov or @vsavkin can you help Todd merge this?

@tvolkert
Copy link
Author

tvolkert commented Oct 1, 2016

Weird - https://pub.dartlang.org/packages/observe is on version 0.14.0

@tvolkert
Copy link
Author

tvolkert commented Oct 2, 2016

Looks like this needs to wait until an update to polymer is published

dart-archive/polymer-expressions#9
dart-archive/polymer-dart#715

@tvolkert
Copy link
Author

tvolkert commented Oct 2, 2016

Actually, the problem seems to be with the introduction of the dependency on package:test (via package:observable and package:observe).

@tvolkert
Copy link
Author

tvolkert commented Oct 2, 2016

wtf?

$ pub get
Resolving dependencies... (2.7s) 
Package test has no versions that match >=0.12.3 <0.13.0 derived from:
- angular depends on version any
- code_transformers 0.3.1 depends on version >=0.12.1 <0.13.0
- guinness2 0.0.3 depends on version ^0.12.3

@tvolkert
Copy link
Author

tvolkert commented Oct 2, 2016

Huh, I actually get the following error trying to run pub get in against head...

$ pub get
Resolving dependencies... (10.6s) 
Package test has no versions that match >=0.12.3 <0.13.0 derived from:
- code_transformers 0.3.1 depends on version >=0.12.1 <0.13.0
- guinness2 0.0.3 depends on version ^0.12.3

@tvolkert
Copy link
Author

tvolkert commented Oct 4, 2016

There's a version tangle here that I don't have time to work through. If someone wants to land this PR, they'll have to update some version dependencies in pubspec.yaml

@matanlurey
Copy link

I think it's OK to keep Angular Dart 1 using the deprecated package for the time being - we aren't expecting any new users and old users are moving to Angular Dart 2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants